Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locksmith): Fix lock processing across networks #15388

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix(locksmith): Fix lock processing across networks #15388

merged 2 commits into from
Jan 22, 2025

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Jan 22, 2025

Description

This PR introduces a change that fixes an issue where locks could be incorrectly marked as processed across different networks.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 January 22, 2025 20:02
@cla-bot cla-bot bot added the cla-signed label Jan 22, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Jan 22, 2025 8:04pm
unlock-storybook ⬜️ Ignored (Inspect) Jan 22, 2025 8:04pm

@julien51 julien51 merged commit 4ed31df into master Jan 22, 2025
16 checks passed
@julien51 julien51 deleted the fix-locks-worker branch January 22, 2025 20:15
julien51 pushed a commit that referenced this pull request Jan 22, 2025
@0xTxbi @julien51
fix(locksmith): Fix lock processing across networks (#15388)
6c1de6b 
update worker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xTxbi @julien51